Re: [PATCH 3/3] KVM: arm64: Use kvm_write_guest_lock when init stolen time

[Steven Price]

On 17/08/2020 04:37, Keqian Zhu wrote:

There is a lock version kvm_write_guest. Use it to simplify code.

Signed-off-by: Keqian Zhu <zhukeqi...@huawei.com>

Reviewed-by: Steven Price <steven.pr...@arm.com>

---
  arch/arm64/kvm/pvtime.c | 6 +-----
  1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm64/kvm/pvtime.c b/arch/arm64/kvm/pvtime.c
index f7b52ce..2b24e7f 100644
--- a/arch/arm64/kvm/pvtime.c
+++ b/arch/arm64/kvm/pvtime.c
@@ -55,7 +55,6 @@ gpa_t kvm_init_stolen_time(struct kvm_vcpu *vcpu)
        struct pvclock_vcpu_stolen_time init_values = {};
        struct kvm *kvm = vcpu->kvm;
        u64 base = vcpu->arch.steal.base;
-       int idx;

if (base == GPA_INVALID)

                return base;
@@ -66,10 +65,7 @@ gpa_t kvm_init_stolen_time(struct kvm_vcpu *vcpu)
         */
        vcpu->arch.steal.steal = 0;
        vcpu->arch.steal.last_steal = current->sched_info.run_delay;
-
-       idx = srcu_read_lock(&kvm->srcu);
-       kvm_write_guest(kvm, base, &init_values, sizeof(init_values));
-       srcu_read_unlock(&kvm->srcu, idx);
+       kvm_write_guest_lock(kvm, base, &init_values, sizeof(init_values));

return base;

  }