> -----Original Message-----
> From: Vinod Koul <vk...@kernel.org>
> Sent: Tuesday, August 18, 2020 2:36 PM
> To: Bard Liao <yung-chuan.l...@linux.intel.com>
> Cc: alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; ti...@suse.de;
> broo...@kernel.org; gre...@linuxfoundation.org; j...@cadence.com;
> srinivas.kandaga...@linaro.org; rander.w...@linux.intel.com;
> ranjani.sridha...@linux.intel.com; hui.w...@canonical.com; pierre-
> louis.boss...@linux.intel.com; Kale, Sanyog R <sanyog.r.k...@intel.com>; Lin,
> Mengdong <mengdong....@intel.com>; Liao, Bard <bard.l...@intel.com>
> Subject: Re: [PATCH 1/2] soundwire: add definition for maximum number of
> ports
>
> On 18-08-20, 01:47, Bard Liao wrote:
> > From: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com>
> >
> > A Device may have at most 15 physical ports (DP0, DP1..DP14).
> >
> > Signed-off-by: Pierre-Louis Bossart
> > <pierre-louis.boss...@linux.intel.com>
> > Reviewed-by: Rander Wang <rander.w...@linux.intel.com>
> > Reviewed-by: Guennadi Liakhovetski
> > <guennadi.liakhovet...@linux.intel.com>
> > Signed-off-by: Bard Liao <yung-chuan.l...@linux.intel.com>
> > ---
> > include/linux/soundwire/sdw.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/linux/soundwire/sdw.h
> > b/include/linux/soundwire/sdw.h index 76052f12c9f7..0aa4c6af7554
> > 100644
> > --- a/include/linux/soundwire/sdw.h
> > +++ b/include/linux/soundwire/sdw.h
> > @@ -38,7 +38,8 @@ struct sdw_slave;
> > #define SDW_FRAME_CTRL_BITS 48
> > #define SDW_MAX_DEVICES 11
> >
> > -#define SDW_VALID_PORT_RANGE(n) ((n) <= 14 && (n) >= 1)
> > +#define SDW_MAX_PORTS 15
> > +#define SDW_VALID_PORT_RANGE(n) ((n) <
> SDW_MAX_PORTS && (n) >= 1)
>
> What is the use of this one if we are allocating all ports always, Also, I
> dont
> see it used in second patch?
It is used in drivers/soundwire/stream.c and drivers/soundwire/debugfs.c.
>
> >
> > enum {
> > SDW_PORT_DIRN_SINK = 0,
> > --
> > 2.17.1
>
> --
> ~Vinod
