On Tue, Sep 1, 2020 at 3:10 PM Kim Phillips <[email protected]> wrote: > > The ITLB Instruction Fetch Hits event isn't documented even in > later zen1 PPRs, but it seems to count correctly on zen1 hardware. > > Add it to zen1 group so zen1 users can use the upcoming IC Fetch Miss > Ratio Metric. > > The IF1G, 1IF2M, IF4K (Instruction fetches to a 1 GB, 2 MB, and 4K page) > unit masks are not added because unlike zen2 hardware, zen1 hardware > counts all its unit masks with a 0 unit mask according to the old > convention: > > zen1$ perf stat -e cpu/event=0x94/,cpu/event=0x94,umask=0xff/ sleep 1 > > Performance counter stats for 'sleep 1': > > 211,318 cpu/event=0x94/u > 211,318 cpu/event=0x94,umask=0xff/u > > Rome/zen2: > > zen2$ perf stat -e cpu/event=0x94/,cpu/event=0x94,umask=0xff/ sleep 1 > > Performance counter stats for 'sleep 1': > > 0 cpu/event=0x94/u > 190,744 cpu/event=0x94,umask=0xff/u > > Signed-off-by: Kim Phillips <[email protected]>
Acked-by: Ian Rogers <[email protected]> Thanks, Ian > Cc: Peter Zijlstra <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Arnaldo Carvalho de Melo <[email protected]> > Cc: Mark Rutland <[email protected]> > Cc: Alexander Shishkin <[email protected]> > Cc: Jiri Olsa <[email protected]> > Cc: Namhyung Kim <[email protected]> > Cc: Vijay Thakkar <[email protected]> > Cc: Andi Kleen <[email protected]> > Cc: John Garry <[email protected]> > Cc: Kan Liang <[email protected]> > Cc: Yunfeng Ye <[email protected]> > Cc: Jin Yao <[email protected]> > Cc: "Martin Liška" <[email protected]> > Cc: Borislav Petkov <[email protected]> > Cc: Jon Grimm <[email protected]> > Cc: Martin Jambor <[email protected]> > Cc: Michael Petlan <[email protected]> > Cc: William Cohen <[email protected]> > Cc: Stephane Eranian <[email protected]> > Cc: Ian Rogers <[email protected]> > Cc: [email protected] > Cc: [email protected] > --- > tools/perf/pmu-events/arch/x86/amdzen1/branch.json | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/perf/pmu-events/arch/x86/amdzen1/branch.json > b/tools/perf/pmu-events/arch/x86/amdzen1/branch.json > index a9943eeb8d6b..4ceb67a0db21 100644 > --- a/tools/perf/pmu-events/arch/x86/amdzen1/branch.json > +++ b/tools/perf/pmu-events/arch/x86/amdzen1/branch.json > @@ -19,5 +19,10 @@ > "EventName": "bp_de_redirect", > "EventCode": "0x91", > "BriefDescription": "Decoder Overrides Existing Branch Prediction > (speculative)." > + }, > + { > + "EventName": "bp_l1_tlb_fetch_hit", > + "EventCode": "0x94", > + "BriefDescription": "The number of instruction fetches that hit in the > L1 ITLB." > } > ] > -- > 2.27.0 >
