On Tue, Sep 15, 2020 at 11:06 AM Joakim Zhang <[email protected]> wrote: > From: Andy Shevchenko <[email protected]> > Sent: 2020年9月15日 15:18 > To: Joakim Zhang <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; dl-linux-imx <[email protected]> > Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle > system > On Tuesday, September 15, 2020, Joakim Zhang <[email protected]> wrote:
> + ret = pm_runtime_get(dev); > + if (ret < 0) > > > > Here is reference counter leak. > > > > Thanks Andy for your kindly review. > > pm_runtime_get increase the usage_count even it fails, so need call > pm_runtime_put_noidle here to balance the usage_count. Am I right? Yes. > + return IRQ_NONE; -- With Best Regards, Andy Shevchenko

