On 17/09/2020 16:28, Srinivas Kandagatla wrote:
GFM Muxes in AUDIO_CC control clocks to LPASS WSA and RX Codec Macros.
This patch adds support to these muxes.

Signed-off-by: Srinivas Kandagatla <[email protected]>
---
  drivers/clk/qcom/Kconfig            |   7 +
  drivers/clk/qcom/Makefile           |   1 +
  drivers/clk/qcom/lpass-gfm-sm8250.c | 235 ++++++++++++++++++++++++++++
  3 files changed, 243 insertions(+)
  create mode 100644 drivers/clk/qcom/lpass-gfm-sm8250.c

diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 2eda63b7c46c..4e46fd339e62 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -494,4 +494,11 @@ config KRAITCC
          Support for the Krait CPU clocks on Qualcomm devices.
          Say Y if you want to support CPU frequency scaling.
+config CLK_GFM_LPASS_SM8250
+       tristate "GFM LPASS Clocks"

Since this driver can be built as module, few things are missing (see below).

+       depends on SND_SOC_QDSP6_COMMON
+       help
+         Support for the GFM Glitch Free Mux LPASS clock. Say Y
+         if you want to support GFM Clocks on LPASS for SM8250 SoC.
+

[skipped]

+
+static const struct of_device_id lpass_gfm_clk_match_table[] = {
+       {
+               .compatible = "qcom,sm8250-lpass-audiocc",
+               .data = &audiocc_data,
+       },
+       { }
+};

MODULE_DEVICE_TABLE(of, lpass_gfm_clk_match_table);

+
+static struct platform_driver lpass_gfm_clk_driver = {
+       .probe          = lpass_gfm_clk_driver_probe,
+       .driver         = {
+               .name   = "lpass-gfm-clk",
+               .of_match_table = lpass_gfm_clk_match_table,
+       },
+};
+builtin_platform_driver(lpass_gfm_clk_driver);


Wouldn't you like to use module_platform_driver() here, like other LPASS CC drivers do?

Also MODULE_LICENSE is missing.


--
With best wishes
Dmitry

Reply via email to