On Thu, Oct 08, 2020 at 11:30:42AM +0200, Borislav Petkov wrote: > On Wed, Oct 07, 2020 at 03:53:48PM -0400, Arvind Sankar wrote: > > Move get_cmd_line_ptr() and COMMAND_LINE_SIZE into misc.h for easier > > use from multiple files. > > Well, I don't like that. cmdline.c *is* for cmdline-related things. > misc.h is a dumping ground for everything but the kitchen sink. > > Why can't you leave it there and make it visible to other compilation > units? >
Are you ok with the include of setup.h? I made the function inline because it's a tiny function, but I can simply add a prototype if that's preferred. KASLR does use it as one more memory region to avoid, rather than just for parsing the command line. Thanks.
