On Thu, Oct 08, 2020 at 05:10:47PM +0200, Borislav Petkov wrote: > On Thu, Oct 08, 2020 at 09:47:23AM -0400, Arvind Sankar wrote: > > Are you ok with the include of setup.h? > > Or you could simply add cmdline.h and include that. It is high time we > started cleaning up that include hell in compressed/ and all facilities > there be nicely separated. Recently I started untangling it but it is a > serious mess. And kernel proper includes leak in there, yuck. >
Ok, I can do that. I'm working on a couple of separate series to clean up cmdline and the compressed boot code a bit. I was actually planning to get rid of boot/compressed/cmdline.c entirely, replacing it with arch/x86/lib/cmdline.c instead: that one's better and is reusable as-is for the decompressor stub, instead of the current hack to use the real-mode boot stub's cmdline.c. The real mess in there is all the includes of .c files from various places.
