Hi Krzysztof, On Thu, Oct 08, 2020 at 12:32:58PM +0200, Krzysztof Kozlowski wrote: > On Wed, Oct 07, 2020 at 05:37:44PM -0700, Nicolin Chen wrote: > > This is a cleanup change to prepare for new swgroups. > > What type of cleanup? Any functional change?
It's to sort the swgroup list by reg address as I mentioned in the subject. Perhaps I should have put in commit message also. > > > > Signed-off-by: Nicolin Chen <[email protected]> > > --- > > drivers/memory/tegra/tegra210.c | 20 ++++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/memory/tegra/tegra210.c > > b/drivers/memory/tegra/tegra210.c > > index e8a7d266802c..b400802c9f14 100644 > > --- a/drivers/memory/tegra/tegra210.c > > +++ b/drivers/memory/tegra/tegra210.c > > @@ -1020,32 +1020,32 @@ static const struct tegra_mc_client > > tegra210_mc_clients[] = { > > }; > > > > static const struct tegra_smmu_swgroup tegra210_swgroups[] = { > > - { .name = "dc", .swgroup = TEGRA_SWGROUP_DC, .reg = 0x240 > > }, > > - { .name = "dcb", .swgroup = TEGRA_SWGROUP_DCB, .reg = 0x244 > > }, > > { .name = "afi", .swgroup = TEGRA_SWGROUP_AFI, .reg = 0x238 > > }, > > { .name = "avpc", .swgroup = TEGRA_SWGROUP_AVPC, .reg = 0x23c > > }, > > - { .name = "hda", .swgroup = TEGRA_SWGROUP_HDA, .reg = 0x254 > > }, > > + { .name = "dc", .swgroup = TEGRA_SWGROUP_DC, .reg = 0x240 > > }, > > + { .name = "dcb", .swgroup = TEGRA_SWGROUP_DCB, .reg = 0x244 > > }, > > { .name = "hc", .swgroup = TEGRA_SWGROUP_HC, .reg = 0x250 > > }, > > + { .name = "hda", .swgroup = TEGRA_SWGROUP_HDA, .reg = 0x254 > > }, > > + { .name = "isp2", .swgroup = TEGRA_SWGROUP_ISP2, .reg = 0x258 > > }, > > { .name = "nvenc", .swgroup = TEGRA_SWGROUP_NVENC, .reg = 0x264 > > }, > > { .name = "ppcs", .swgroup = TEGRA_SWGROUP_PPCS, .reg = 0x270 > > }, > > { .name = "sata", .swgroup = TEGRA_SWGROUP_SATA, .reg = 0x274 > > }, > > - { .name = "isp2", .swgroup = TEGRA_SWGROUP_ISP2, .reg = 0x258 > > }, > > + { .name = "vi", .swgroup = TEGRA_SWGROUP_VI, .reg = 0x280 > > }, > > + { .name = "vic", .swgroup = TEGRA_SWGROUP_VIC, .reg = 0x284 > > }, > > { .name = "xusb_host", .swgroup = TEGRA_SWGROUP_XUSB_HOST, .reg = 0x288 > > }, > > { .name = "xusb_dev", .swgroup = TEGRA_SWGROUP_XUSB_DEV, .reg = 0x28c > > }, > > - { .name = "isp2b", .swgroup = TEGRA_SWGROUP_ISP2B, .reg = 0xaa4 > > }, > > - { .name = "tsec", .swgroup = TEGRA_SWGROUP_TSEC, .reg = 0x294 > > }, > > { .name = "a9avp", .swgroup = TEGRA_SWGROUP_A9AVP, .reg = 0x290 > > }, > > I must say I cannot find the order. By name - not. By swgroup name - > not. By register - not. > > What is the order then? It's by "reg" as I mentioned in the commit subject. Probably it's not that obvious by looking at the change itself :-/ Its following change of adding new swgroups would be easier to insert by following the same order of "reg" addresses. Thanks
