On Fri, Oct 9, 2020 at 5:57 AM Greg KH <[email protected]> wrote: > > On Thu, Oct 08, 2020 at 11:57:13PM +0530, Harshal Chaudhari wrote: > > Checking the argument passed to the ioctl is valid > > or not. if not then return -EINVAL. > > Along the the comments that Arnd made, this is not the correct value to > be returning from an ioctl when you don't pass in the correct command. > > And it doesn't match what your patch says, please be consistent. > > And do you have this device to be able to test your changes?
I will test this tomorrow. But from an initial look, its going to break ppdev. There are few ioctls which don't need any arguments. -- Regards Sudip
