On Tue, Sep 29, 2020 at 10:27:21AM -0700, Florian Fainelli wrote:
> With commit 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE
> detection"), we generate a reference to fw_arg3 which is the fourth
> firmware/command line argument on MIPS platforms. That symbol is not
> exported and would cause a linking failure.
>
> The parser is typically necessary to boot a BCM63xx-based system anyway
> so having it be part of the kernel image makes sense, therefore make it
> 'bool' instead of 'tristate'.
>
> Fixes: 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE detection")
> Signed-off-by: Florian Fainelli <[email protected]>
What happened with this patch ? The build failure is still seen in mainline
and in next-20201009.
Guenter
> ---
> drivers/mtd/parsers/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/parsers/Kconfig b/drivers/mtd/parsers/Kconfig
> index f98363c9b363..e72354322f62 100644
> --- a/drivers/mtd/parsers/Kconfig
> +++ b/drivers/mtd/parsers/Kconfig
> @@ -12,7 +12,7 @@ config MTD_BCM47XX_PARTS
> boards.
>
> config MTD_BCM63XX_PARTS
> - tristate "BCM63XX CFE partitioning parser"
> + bool "BCM63XX CFE partitioning parser"
> depends on BCM63XX || BMIPS_GENERIC || COMPILE_TEST
> select CRC32
> select MTD_PARSER_IMAGETAG
> --
> 2.25.1
>
