On Sun, Oct 11, 2020 at 01:09:55PM -0700, t...@redhat.com wrote: > From: Tom Rix <t...@redhat.com> > > Clang static analysis reports this representative problem > > ptp_clockmatrix.c:1852:2: warning: 5th function call argument > is an uninitialized value > snprintf(idtcm->version, sizeof(idtcm->version), "%u.%u.%u", > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > idtcm_display_version_info() calls several idtcm_read_*'s without > checking a return status.
So why not check the return status? Your patch papers over the issue. Thanks, Richard
