Hello, On Fri, Nov 6, 2020 at 12:33 PM <[email protected]> wrote: > > From: Kaixu Xia <[email protected]> > > Here we could use the '!=' expression to fix the following coccicheck > warning: > > ./tools/perf/builtin-script.c:3209:48-53: WARNING: conversion to bool not > needed here > ./tools/perf/builtin-script.c:2761:36-41: WARNING: conversion to bool not > needed here > > Reported-by: Tosk Robot <[email protected]> > Signed-off-by: Kaixu Xia <[email protected]>
Acked-by: Namhyung Kim <[email protected]> Thanks, Namhyung > --- > tools/perf/builtin-script.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > index 48588ccf902e..b5a6fd63ca5f 100644 > --- a/tools/perf/builtin-script.c > +++ b/tools/perf/builtin-script.c > @@ -2758,7 +2758,7 @@ static int parse_output_fields(const struct option *opt > __maybe_unused, > break; > } > if (i == imax && strcmp(tok, "flags") == 0) { > - print_flags = change == REMOVE ? false : true; > + print_flags = change != REMOVE; > continue; > } > if (i == imax) { > @@ -3206,7 +3206,7 @@ static char *get_script_path(const char *script_root, > const char *suffix) > > static bool is_top_script(const char *script_path) > { > - return ends_with(script_path, "top") == NULL ? false : true; > + return ends_with(script_path, "top") != NULL; > } > > static int has_required_arg(char *script_path) > -- > 2.20.0 >
