On Wed, 5 Dec 2007, Geoff Levand wrote: > Andrew Morton wrote: > > On Wed, 5 Dec 2007 10:52:48 +0100 (CET) > > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > > >> -------------------------------------------------------------------------------- > >> Subject: sparsemem: sparse_add_one_section() may fail to allocate memory > >> > >> sparsemem: sparse_add_one_section() may fail to allocate memory, and must > >> check > >> whether the allocation succeeded before proceeding to touch the allocated > >> memory. > >> > >> From: Geert Uytterhoeven <[EMAIL PROTECTED]> > >> > >> Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> > >> --- > >> FIXME There are still some possible memory leaks in > >> sparse_add_one_section(): > >> - usemap is never deallocated > >> - __kfree_section_memmap() is a not yet implemented dummy > > > > I already had > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/broken-out/mm-sparsec-improve-the-error-handling-for-sparse_add_one_section.patch > > and > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/broken-out/mm-sparsec-check-the-return-value-of-sparse_index_alloc.patch > > > > queued. Do they fix the problem, and should they be merged in 2.6.24? > > No, a quick test shows it just panics in a different place. Geert's > patch does also.
What do you mean, that it still paniced after my patch? The kernel did boot succesfully for me when passing ps3fb=48M. Userspace saw 58 MiB (128 MiB - kernelsize - 48 MiB(ps3fb)). I did not try kexec, though. With kind regards, Geert Uytterhoeven Software Architect Sony Network and Software Technology Center Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: [EMAIL PROTECTED] Internet: http://www.sony-europe.com/ Sony Network and Software Technology Center Europe A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619