On Wed, Nov 11, 2020 at 11:21:12AM -0800, Bhaumik Bhatt wrote: > The __mhi_unprepare_channel() API does not require the __ prefix. > Get rid of it and make the internal function consistent with the > other function names. > > Signed-off-by: Bhaumik Bhatt <[email protected]>
Reviewed-by: Manivannan Sadhasivam <[email protected]> Thanks, Mani > --- > drivers/bus/mhi/core/main.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > index e8af85a..19156d4 100644 > --- a/drivers/bus/mhi/core/main.c > +++ b/drivers/bus/mhi/core/main.c > @@ -1312,8 +1312,8 @@ static int mhi_update_channel_state(struct > mhi_controller *mhi_cntrl, > return -EINVAL; > } > > -static void __mhi_unprepare_channel(struct mhi_controller *mhi_cntrl, > - struct mhi_chan *mhi_chan) > +static void mhi_unprepare_channel(struct mhi_controller *mhi_cntrl, > + struct mhi_chan *mhi_chan) > { > int ret; > struct device *dev = &mhi_cntrl->mhi_dev->dev; > @@ -1433,7 +1433,7 @@ int mhi_prepare_channel(struct mhi_controller > *mhi_cntrl, > > error_pre_alloc: > mutex_unlock(&mhi_chan->mutex); > - __mhi_unprepare_channel(mhi_cntrl, mhi_chan); > + mhi_unprepare_channel(mhi_cntrl, mhi_chan); > > return ret; > } > @@ -1550,7 +1550,7 @@ int mhi_prepare_for_transfer(struct mhi_device *mhi_dev) > if (!mhi_chan) > continue; > > - __mhi_unprepare_channel(mhi_cntrl, mhi_chan); > + mhi_unprepare_channel(mhi_cntrl, mhi_chan); > } > > return ret; > @@ -1568,7 +1568,7 @@ void mhi_unprepare_from_transfer(struct mhi_device > *mhi_dev) > if (!mhi_chan) > continue; > > - __mhi_unprepare_channel(mhi_cntrl, mhi_chan); > + mhi_unprepare_channel(mhi_cntrl, mhi_chan); > } > } > EXPORT_SYMBOL_GPL(mhi_unprepare_from_transfer); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
