Hello,
On Wed, Nov 25, 2020 at 10:31:06AM +0100, Uwe Kleine-König wrote:
> The driver core ignores the return value of the remove callback, so
> don't give siox drivers the chance to provide a value.
>
> All siox drivers only allocate devm-managed resources in
> .probe, so there is no .remove callback to fix.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
Acked-by: Thorsten Scherer <t.sche...@eckelmann.de>
> ---
> drivers/siox/siox-core.c | 5 ++---
> include/linux/siox.h | 2 +-
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
> index b56cdcb52967..1794ff0106bc 100644
> --- a/drivers/siox/siox-core.c
> +++ b/drivers/siox/siox-core.c
> @@ -525,12 +525,11 @@ static int siox_remove(struct device *dev)
> struct siox_driver *sdriver =
> container_of(dev->driver, struct siox_driver, driver);
> struct siox_device *sdevice = to_siox_device(dev);
> - int ret = 0;
>
> if (sdriver->remove)
> - ret = sdriver->remove(sdevice);
> + sdriver->remove(sdevice);
>
> - return ret;
> + return 0;
> }
>
> static void siox_shutdown(struct device *dev)
> diff --git a/include/linux/siox.h b/include/linux/siox.h
> index da7225bf1877..6bfbda3f634c 100644
> --- a/include/linux/siox.h
> +++ b/include/linux/siox.h
> @@ -36,7 +36,7 @@ bool siox_device_connected(struct siox_device *sdevice);
>
> struct siox_driver {
> int (*probe)(struct siox_device *sdevice);
> - int (*remove)(struct siox_device *sdevice);
> + void (*remove)(struct siox_device *sdevice);
> void (*shutdown)(struct siox_device *sdevice);
>
> /*
> --
> 2.29.2
>
Kind regards
Thorsten
--
Thorsten Scherer | Eckelmann AG | www.eckelmann.de |
