[AMD Public Use]
Reviewed-by: Guchun Chen <guchun.c...@amd.com>
Regards,
Guchun
-----Original Message-----
From: Colin King <colin.k...@canonical.com>
Sent: Wednesday, November 25, 2020 10:18 PM
To: Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian
<christian.koe...@amd.com>; David Airlie <airl...@linux.ie>; Daniel Vetter
<dan...@ffwll.ch>; Zhou1, Tao <tao.zh...@amd.com>; Chen, Guchun
<guchun.c...@amd.com>; amd-...@lists.freedesktop.org;
dri-de...@lists.freedesktop.org
Cc: kernel-janit...@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH][next] drm/amdgpu: Fix sizeof() mismatch in bps_bo
kmalloc_array creation
From: Colin Ian King <colin.k...@canonical.com>
An incorrect sizeof() is being used, sizeof((*data)->bps_bo) is not correct, it
should be sizeof(*(*data)->bps_bo). It just so happens to work because the
sizes are the same. Fix it.
Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)")
Fixes: 5278a159cf35 ("drm/amdgpu: support reserve bad page for virt (v3)")
Signed-off-by: Colin Ian King <colin.k...@canonical.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 2d51b7694d1f..df15d33e3c5c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -283,7 +283,7 @@ static int amdgpu_virt_init_ras_err_handler_data(struct
amdgpu_device *adev)
return -ENOMEM;
bps = kmalloc_array(align_space, sizeof((*data)->bps), GFP_KERNEL);
- bps_bo = kmalloc_array(align_space, sizeof((*data)->bps_bo),
GFP_KERNEL);
+ bps_bo = kmalloc_array(align_space, sizeof(*(*data)->bps_bo),
+GFP_KERNEL);
if (!bps || !bps_bo) {
kfree(bps);
--
2.29.2
