Em Fri, Nov 27, 2020 at 10:35:37PM +0900, Namhyung Kim escreveu:
> Hello,
>
> On Tue, Nov 24, 2020 at 7:37 PM Zhen Lei <[email protected]> wrote:
> >
> > An appropriate return value should be set on the failed path.
> >
> > Reported-by: Hulk Robot <[email protected]>
> > Signed-off-by: Zhen Lei <[email protected]>
>
> Acked-by: Namhyung Kim <[email protected]>
Thanks, applied.
- Arnaldo
> Thanks,
> Namhyung
>
> > ---
> > tools/perf/builtin-diff.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> > index 584e2e1a3793..cefc71506409 100644
> > --- a/tools/perf/builtin-diff.c
> > +++ b/tools/perf/builtin-diff.c
> > @@ -1222,8 +1222,10 @@ static int __cmd_diff(void)
> > if (compute == COMPUTE_STREAM) {
> > d->evlist_streams = evlist__create_streams(
> > d->session->evlist, 5);
> > - if (!d->evlist_streams)
> > + if (!d->evlist_streams) {
> > + ret = -ENOMEM;
> > goto out_delete;
> > + }
> > }
> > }
> >
> > --
> > 2.26.0.106.g9fadedd
> >
> >
--
- Arnaldo
