On Mon, Nov 30, 2020 at 6:37 PM Bartosz Golaszewski <[email protected]> wrote: > > On Thu, Nov 19, 2020 at 4:04 PM Andy Shevchenko > <[email protected]> wrote: > > > > On Thu, Nov 19, 2020 at 4:17 PM Alexandru Ardelean > > <[email protected]> wrote: > > > > > > There is no matching spi_get_drvdata() call in the driver, so there is no > > > need to do spi_set_drvdata(). This looks like it probably was copied from > > > a > > > driver that used both spi_set_drvdata() & spi_get_drvdata(). > > > > While above luckily (*) okay it may not always be the case. > > > > *) it can be paired with dev_get_drvdata() which is usual for PM callbacks. > > > > With amended commit message > > Reviewed-by: Andy Shevchenko <[email protected]> > > > > I applied this patch. I wasn't sure exactly how you want the commit > message to be changed - it sounds pretty clear to me so I took it.
For example, by adding " or dev_get_drvdata()" to the end. -- With Best Regards, Andy Shevchenko
