On Thu, Dec 03, 2020 at 10:45:48AM -0600, Tom Lendacky wrote: > Since this is based on the array size, can > > idx < NUM_LEGACY_PREFIXES > > be replaced with: > > idx < ARRAY_SIZE(insn->prefixes.bytes)
Actually, this needs another change: struct insn_field { union { insn_value_t value; insn_byte_t bytes[NUM_LEGACY_PREFIXES]; because you can have max. 4 legacy prefixes and then we can do either of the checks above. Mine is shorter tho. :-) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette