Hi Dave, On 07/12/20 9:25 pm, Jiang, Dave wrote: > > >> -----Original Message----- >> From: Kishon Vijay Abraham I <[email protected]> >> Sent: Wednesday, November 11, 2020 8:36 AM >> To: Bjorn Helgaas <[email protected]>; Jonathan Corbet >> <[email protected]>; Kishon Vijay Abraham I <[email protected]>; Lorenzo >> Pieralisi <[email protected]>; Arnd Bergmann <[email protected]>; >> Jon Mason <[email protected]>; Jiang, Dave <[email protected]>; >> Allen Hubbe <[email protected]>; Tom Joseph <[email protected]>; >> Rob Herring <[email protected]> >> Cc: Greg Kroah-Hartman <[email protected]>; linux- >> [email protected]; [email protected]; linux- >> [email protected]; [email protected] >> Subject: [PATCH v8 16/18] NTB: tool: Enable the NTB/PCIe link on the local or >> remote side of bridge >> >> Invoke ntb_link_enable() to enable the NTB/PCIe link on the local or remote >> side of the bridge. >> >> Signed-off-by: Kishon Vijay Abraham I <[email protected]> >> --- >> drivers/ntb/test/ntb_tool.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c index >> b7bf3f863d79..8230ced503e3 100644 >> --- a/drivers/ntb/test/ntb_tool.c >> +++ b/drivers/ntb/test/ntb_tool.c >> @@ -1638,6 +1638,7 @@ static int tool_probe(struct ntb_client *self, struct >> ntb_dev *ntb) >> >> tool_setup_dbgfs(tc); >> >> + ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO); > > The tool expects the user to enable the link via debugfs according to > documentation. Is this necessary?
right, it can be enabled using debugfs. Will drop this patch. Thank You, Kishon
