On Tue, Dec 18, 2007 at 11:02:37AM +1100, Benjamin Herrenschmidt wrote: > +EXPORT_SYMBOL(pci_enable_device_io); > +EXPORT_SYMBOL(pci_enable_device_mem); > EXPORT_SYMBOL(pci_enable_device);
Wouldn't it be better to export only the pci_enable_device_flags() and make these three just "static inline" wrappers in pci.h? > EXPORT_SYMBOL(pcim_enable_device); Looks like many SATA drivers would benefit from pcim_* equivalents of pci_enable_device_{io,mem}, as they could happily work with just a single MMIO BAR... Alan? Ivan. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/