On Mon, 2020-12-21 at 13:55 +1100, Stephen Rothwell wrote: > Hi Kuan-Ying, > > On Mon, 21 Dec 2020 10:31:38 +0800 Kuan-Ying Lee <[email protected]> > wrote: > > > > On Mon, 2020-12-21 at 13:10 +1100, Stephen Rothwell wrote: > > > > > > After merging the akpm-current tree, today's linux-next build (x86_64 > > > allmodconfig) failed like this: > > > > > > mm/kasan/quarantine.c: In function 'quarantine_put': > > > mm/kasan/quarantine.c:207:15: error: 'info' undeclared (first use in this > > > function) > > > 207 | qlink_free(&info->quarantine_link, cache); > > > | ^~~~ > > > > > > Caused by commit > > > > > > 120d593a8650 ("kasan: fix memory leak of kasan quarantine") > > > > > > interacting with commit > > > > > > cfbc92088e1d ("kasan: rename get_alloc/free_info") > > > > > > Can we please get this sorted out once and for all? > > > > > > I have applied the following patch for today: > > > > > > From: Stephen Rothwell <[email protected]> > > > Date: Mon, 21 Dec 2020 13:07:42 +1100 > > > Subject: [PATCH] kasan: fix memory leak of kasan quarantine fix > > > > > > Signed-off-by: Stephen Rothwell <[email protected]> > > > --- > > > mm/kasan/quarantine.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c > > > index 3f3b3d902c18..091a57f942b3 100644 > > > --- a/mm/kasan/quarantine.c > > > +++ b/mm/kasan/quarantine.c > > > @@ -204,7 +204,7 @@ bool quarantine_put(struct kmem_cache *cache, void > > > *object) > > > > > > q = this_cpu_ptr(&cpu_quarantine); > > > if (q->offline) { > > > - qlink_free(&info->quarantine_link, cache); > > > + qlink_free(&meta->quarantine_link, cache); // free once > > > local_irq_restore(flags); > > > return false; // free twice > > > } > > > -- > > > 2.29.2 > > > > > > > Please just drop this patch "kasan: fix memory leak of kasan quarantine" > > from linux-next. Otherwise, it would cause double free issue. > > OK, so for today I have reverted my fix patch and 120d593a8650 ("kasan: > fix memory leak of kasan quarantine"). >
Dear Andrew, I am sorry. I didn't mean to. This patch has build error. https://www.ozlabs.org/~akpm/mmotm/broken-out/kasan-fix-memory-leak-of-kasan-quarantine.patch Sorry to make the build errors and merge issues repeatedly. My fix has dependency issues with Andrey's patches [1, 2], and I think it's better to merge Andrey's patches first and I will push a fix after Andrey's patch. Please just drop this patch from akpm-tree directly. [1]https://www.ozlabs.org/~akpm/mmotm/broken-out/kasan-sanitize-objects-when-metadata-doesnt-fit.patch [2]https://www.ozlabs.org/~akpm/mmotm/broken-out/kasan-rename-get_alloc-free_info.patch Thanks.
