On Tue, Dec 22, 2020 at 09:33:44PM +0800, Zheng Yongjun wrote: > Don't open-code DIV_ROUND_UP() kernel macro. > > Signed-off-by: Zheng Yongjun <zhengyongj...@huawei.com> > --- > drivers/misc/kgdbts.c | 5 ++---
Arguably this patch should have kgdbts in the Subject line. > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c > index 945701bce553..cd086921a792 100644 > --- a/drivers/misc/kgdbts.c > +++ b/drivers/misc/kgdbts.c > @@ -139,9 +139,8 @@ static int restart_from_top_after_write; > static int sstep_state; > > /* Storage for the registers, in GDB format. */ > -static unsigned long kgdbts_gdb_regs[(NUMREGBYTES + > - sizeof(unsigned long) - 1) / > - sizeof(unsigned long)]; > +static unsigned long kgdbts_gdb_regs[DIV_ROUND_UP(NUMREGBYTES, > + sizeof(unsigned long)i)]; How was this patch tested? This code does not look like it is compilable. Daniel.
