Hi Daniel, On Thu, Dec 24, 2020 at 01:08:58AM +0000, Daniel Scally wrote: > To maintain consistency with software_node_unregister_nodes(), reverse > the order in which the software_node_unregister_node_group() function > unregisters nodes. > > Reported-by: kernel test robot <[email protected]> > Reported-by: Dan Carpenter <[email protected]> > Reviewed-by: Laurent Pinchart <[email protected]> > Suggested-by: Andy Shevchenko <[email protected]> > Signed-off-by: Daniel Scally <[email protected]> > --- > Changes in v3 > - Fixed the dereference of the terminating NULL entry > - Comment cleanup > > drivers/base/swnode.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c > index ade49173ff8d..2d07eb04c6c8 100644 > --- a/drivers/base/swnode.c > +++ b/drivers/base/swnode.c > @@ -779,16 +779,22 @@ EXPORT_SYMBOL_GPL(software_node_register_node_group); > * software_node_unregister_node_group - Unregister a group of software nodes > * @node_group: NULL terminated array of software node pointers to be > unregistered > * > - * Unregister multiple software nodes at once. > + * Unregister multiple software nodes at once. The array will be unwound in > + * reverse order (i.e. last entry first) and thus if any member of the array > + * has its .parent member set then they should appear later in the array such > + * that they are unregistered first. > */ > void software_node_unregister_node_group(const struct software_node > **node_group)
With this line wrapped, Reviewed-by: Sakari Ailus <[email protected]> > { > - unsigned int i; > + unsigned int i = 0; > > if (!node_group) > return; > > - for (i = 0; node_group[i]; i++) > + while (node_group[i]) > + i++; > + > + while (i--) > software_node_unregister(node_group[i]); > } > EXPORT_SYMBOL_GPL(software_node_unregister_node_group); -- Kind regards, Sakari Ailus
