On (20/12/07 13:43), Thomas Bogendoerfer didst pronounce: > On Thu, Dec 20, 2007 at 11:44:06AM +0000, Mel Gorman wrote: > > --- a/include/asm-mips/page.h > > +++ b/include/asm-mips/page.h > > @@ -37,13 +37,6 @@ > > #include <linux/pfn.h> > > #include <asm/io.h> > > > > -/* > > - * It's normally defined only for FLATMEM config but it's > > - * used in our early mem init code for all memory models. > > - * So always define it. > > - */ > > -#define ARCH_PFN_OFFSET PFN_UP(PHYS_OFFSET) > > - > > hmm, doesn't this break what I've fixed ? Without this #define > ARCH_PFN_OFFSET gets defined to 0 and the bug is back. Or did > I miss anything ? >
ARCH_PFN_OFFSET goes to 0, so page_to_pfn() is no longer adjusting by PFN_UP(PHYS_OFFSET) like it was when your problem occured. I am guessing that the nature of the crash was that page_to_pfn() was returning bogus values early in boot and trying to initialise memmap that didn't exist. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
