On Thu, Jan 07, 2021 at 04:51:31PM -0800, Joe Perches wrote: > I still like the stracpy variant I proposed: > > https://lore.kernel.org/lkml/24bb53c57767c1c2a8f266c305a67...@sk2.org/T/#m0627aa770a076af1937cb5c610ed71dab3f1da72 > https://lore.kernel.org/lkml/CAHk-=wgqQKoAnhmhGE-2PBFt7oQs9LLAATKbYa573UO=dpb...@mail.gmail.com/ > > Linus liked a variant he called copy_string: > > https://lore.kernel.org/lkml/CAHk-=wg8vlmmwtghxm51npswjw8rfeakoxxg0hu_q9uwbjj...@mail.gmail.com/ > > I think the cocci scripts that convert: > > strlcpy -> strscpy (only when return value unused) > str<sln>cpy(array, "string") -> stracpy(foo, "string") > s[cn]printf -> sysfs_emit > > would leave relatively few uses of strcpy and sprintf variants and would > make it much easier to analyze the remainder uses for potential overflows.
I think that would be lovely; yes. :) -- Kees Cook
