On Tue, Dec 18, 2007 at 06:46:41AM +0100, Borislav Petkov wrote:
> On Mon, Dec 17, 2007 at 08:11:05AM +0100, Borislav Petkov wrote:
> 
> A slightly microoptimized version 1.1:
> 
> ---
> From: Borislav Petkov <[EMAIL PROTECTED]>
> 
> 
> Check the patch level of the single hunks in a patch file, however only when
> checkpatch.pl is called from within the kernel tree.
> 
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
> --
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 579f50f..3eda27b 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -653,6 +653,18 @@ sub CHK {
>       }
>  }
>  
> +sub check_patchlevel {
> +
> +     if ($tree) {
> +             my ($path) = @_;
> +             $path =~ s![^/]*/!!;
> +
> +             if (!stat($path)) {
> +                     WARN("Check the patchlevel (hint: patch option -p)");
> +             }
> +     }

Hmmm that will trigger on all patches which create new files if I am
grokking you correctly.

I would have thought this would pretty easy to check from the form of
the names.  Hmmm.

> +}
> +
>  sub process {
>       my $filename = shift;
>       my @lines = @_;
> @@ -713,10 +725,16 @@ sub process {
>  #extract the filename as it passes
>               if ($line=~/^\+\+\+\s+(\S+)/) {
>                       $realfile=$1;
> +
> +                     if ($realfile) {
> +                             check_patchlevel($realfile);
> +                     }
> +
>                       $realfile =~ [EMAIL PROTECTED]/]*/@@;
>                       $in_comment = 0;
>                       next;
>               }
> +
>  #extract the line range in the file after the patch is applied
>               if ($line=~/[EMAIL PROTECTED]@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? 
> [EMAIL PROTECTED]@/) {
>                       $is_patch = 1;

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to