The register writes during driver removal occur after the device is
already put back in reset, so they never had any effect.

Signed-off-by: Samuel Holland <sam...@sholland.org>
---
 drivers/media/rc/sunxi-cir.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c
index 8555c7798706..0a7f7eab3cc3 100644
--- a/drivers/media/rc/sunxi-cir.c
+++ b/drivers/media/rc/sunxi-cir.c
@@ -342,22 +342,12 @@ static int sunxi_ir_probe(struct platform_device *pdev)
 
 static int sunxi_ir_remove(struct platform_device *pdev)
 {
-       unsigned long flags;
        struct sunxi_ir *ir = platform_get_drvdata(pdev);
 
        clk_disable_unprepare(ir->clk);
        clk_disable_unprepare(ir->apb_clk);
        reset_control_assert(ir->rst);
 
-       spin_lock_irqsave(&ir->ir_lock, flags);
-       /* disable IR IRQ */
-       writel(0, ir->base + SUNXI_IR_RXINT_REG);
-       /* clear All Rx Interrupt Status */
-       writel(REG_RXSTA_CLEARALL, ir->base + SUNXI_IR_RXSTA_REG);
-       /* disable IR */
-       writel(0, ir->base + SUNXI_IR_CTL_REG);
-       spin_unlock_irqrestore(&ir->ir_lock, flags);
-
        rc_unregister_device(ir->rc);
        return 0;
 }
-- 
2.26.2

Reply via email to