The device node reference obtained with of_get_child_by_name() should be
dropped on error paths.

Fixes: 26aec009f6b6 ("regulator: add device tree support for s5m8767")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
 drivers/regulator/s5m8767.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c
index 3fa472127e9a..fa10f1f550a4 100644
--- a/drivers/regulator/s5m8767.c
+++ b/drivers/regulator/s5m8767.c
@@ -544,14 +544,18 @@ static int s5m8767_pmic_dt_parse_pdata(struct 
platform_device *pdev,
        rdata = devm_kcalloc(&pdev->dev,
                             pdata->num_regulators, sizeof(*rdata),
                             GFP_KERNEL);
-       if (!rdata)
+       if (!rdata) {
+               of_node_put(regulators_np);
                return -ENOMEM;
+       }
 
        rmode = devm_kcalloc(&pdev->dev,
                             pdata->num_regulators, sizeof(*rmode),
                             GFP_KERNEL);
-       if (!rmode)
+       if (!rmode) {
+               of_node_put(regulators_np);
                return -ENOMEM;
+       }
 
        pdata->regulators = rdata;
        pdata->opmode = rmode;
-- 
2.25.1

Reply via email to