Hi Prashant, > -----Original Message----- > From: Prashant Malani <[email protected]> > Sent: Friday, February 05, 2021 12:07 PM > To: Mani, Rajmohan <[email protected]> > Cc: Benson Leung <[email protected]>; Enric Balletbo i Serra > <[email protected]>; Guenter Roeck <[email protected]>; > Linux Kernel Mailing List <[email protected]>; Heikki Krogerus > <[email protected]> > Subject: Re: [PATCH 1/2] platform/chrome: cros_ec_typec: Skip port partner > check in configure_mux() > > Hi Raj, > > On Fri, Feb 5, 2021 at 11:52 AM Rajmohan Mani > <[email protected]> wrote: > > > > For certain needs like updating the USB4 retimer firmware when no > > device are connected, the Type-C ports require mux configuration, to > > be able to communicate with the retimer. So removed the above check to > > allow for mux configuration of Type-C ports, to enable retimer > > communication. > > > > Signed-off-by: Rajmohan Mani <[email protected]> > Reviewed-by: Prashant Malani <[email protected]> >
Thanks for the review of the patch series. > > --- > > drivers/platform/chrome/cros_ec_typec.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/platform/chrome/cros_ec_typec.c > > b/drivers/platform/chrome/cros_ec_typec.c > > index e724a5eaef1c..3d8ff3f8a514 100644 > > --- a/drivers/platform/chrome/cros_ec_typec.c > > +++ b/drivers/platform/chrome/cros_ec_typec.c > > @@ -536,9 +536,6 @@ static int cros_typec_configure_mux(struct > cros_typec_data *typec, int port_num, > > enum typec_orientation orientation; > > int ret; > > > > - if (!port->partner) > > - return 0; > > - > > if (mux_flags & USB_PD_MUX_POLARITY_INVERTED) > > orientation = TYPEC_ORIENTATION_REVERSE; > > else > > -- > > 2.30.0 > >
