On 22/01/2021 14:51, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 19, 2021 at 04:46:51PM +0200, James Clark escreveu: >> From: Leo Yan <[email protected]> >> >> This patch is to enable sample type PERF_SAMPLE_DATA_SRC for Arm SPE in >> the perf data, when output the tracing data, it tells tools that it >> contains data source in the memory event. >> >> Signed-off-by: Leo Yan <[email protected]> >> Signed-off-by: James Clark <[email protected]> > > I see two Signed-off-by, ok, any Reviewed-by? > > - Arnaldo Hi Arnaldo, I have submitted v2 and added my reviewed-by and tested-by. I didn't change any of the authors as Leo suggested because I only modified the last two patches which we dropped anyway to not show any misleading PID data when run from a container. Thanks James > >> Cc: Peter Zijlstra <[email protected]> >> Cc: Ingo Molnar <[email protected]> >> Cc: Arnaldo Carvalho de Melo <[email protected]> >> Cc: Mark Rutland <[email protected]> >> Cc: Alexander Shishkin <[email protected]> >> Cc: Jiri Olsa <[email protected]> >> Cc: Namhyung Kim <[email protected]> >> Cc: John Garry <[email protected]> >> Cc: Will Deacon <[email protected]> >> Cc: Mathieu Poirier <[email protected]> >> Cc: Al Grant <[email protected]> >> Cc: Andre Przywara <[email protected]> >> Cc: Wei Li <[email protected]> >> Cc: Tan Xiaojun <[email protected]> >> Cc: Adrian Hunter <[email protected]> >> --- >> tools/perf/util/arm-spe.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c >> index 8901a1656a41..b134516e890b 100644 >> --- a/tools/perf/util/arm-spe.c >> +++ b/tools/perf/util/arm-spe.c >> @@ -803,7 +803,7 @@ arm_spe_synth_events(struct arm_spe *spe, struct >> perf_session *session) >> attr.type = PERF_TYPE_HARDWARE; >> attr.sample_type = evsel->core.attr.sample_type & PERF_SAMPLE_MASK; >> attr.sample_type |= PERF_SAMPLE_IP | PERF_SAMPLE_TID | >> - PERF_SAMPLE_PERIOD; >> + PERF_SAMPLE_PERIOD | PERF_SAMPLE_DATA_SRC; >> if (spe->timeless_decoding) >> attr.sample_type &= ~(u64)PERF_SAMPLE_TIME; >> else >> -- >> 2.28.0 >> >
