On 2/24/21 2:07 PM, Nick Desaulniers wrote: > On Wed, Feb 24, 2021 at 1:55 PM Randy Dunlap <[email protected]> wrote: >> >> The previously added stubs for aty_{ld,}st_lcd() make it >> so that these functions are used regardless of the config >> options that were guarding them, so remove the #ifdef/#endif >> lines and make their declarations always visible. >> This fixes build warnings that were reported by clang: > > Yes, though I think GCC would warn similarly with W=1 builds as well, > which was set for the 0day bot report. >
<knocks head> I should enable that until it hurts too much. >> >> drivers/video/fbdev/aty/atyfb_base.c:180:6: warning: no previous >> prototype for function 'aty_st_lcd' [-Wmissing-prototypes] >> void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) >> ^ >> drivers/video/fbdev/aty/atyfb_base.c:180:1: note: declare 'static' if the >> function is not intended to be used outside of this translation unit >> void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) >> >> drivers/video/fbdev/aty/atyfb_base.c:183:5: warning: no previous >> prototype for function 'aty_ld_lcd' [-Wmissing-prototypes] >> u32 aty_ld_lcd(int index, const struct atyfb_par *par) >> ^ >> drivers/video/fbdev/aty/atyfb_base.c:183:1: note: declare 'static' if the >> function is not intended to be used outside of this translation unit >> u32 aty_ld_lcd(int index, const struct atyfb_par *par) >> >> They should not be marked as static since they are used in >> mach64_ct.c. > > Probably don't need to be marked extern either (since that's the > implicit default), but I don't feel strongly about it. Yeah, I was just leaving it as it was... > Thanks for sending a cleanup for this. > Acked-by: Nick Desaulniers <[email protected]> > >> >> Fixes: bfa5782b9caa ("fbdev: atyfb: add stubs for aty_{ld,st}_lcd()") >> Signed-off-by: Randy Dunlap <[email protected]> >> Reported-by: kernel test robot <[email protected]> >> Cc: Daniel Vetter <[email protected]> >> Cc: Nick Desaulniers <[email protected]> >> Cc: [email protected] >> Cc: [email protected] >> Cc: Bartlomiej Zolnierkiewicz <[email protected]> >> Cc: Sam Ravnborg <[email protected]> >> Cc: David Airlie <[email protected]> >> Cc: Jani Nikula <[email protected]> >> --- >> drivers/video/fbdev/aty/atyfb.h | 3 --- >> 1 file changed, 3 deletions(-) -- ~Randy
