2008/1/10, Rik van Riel <[EMAIL PROTECTED]>: > On Thu, 10 Jan 2008 18:56:07 +0300 > "Anton Salikhmetov" <[EMAIL PROTECTED]> wrote: > > > However, I don't see how they will work if there has been > > something like a sync(2) done after the mmap'd region is > > modified and the msync call. When the inode is written out > > as part of the sync process, I_DIRTY_PAGES will be cleared, > > thus causing a miss in this code. > > > > The I_DIRTY_PAGES check here is good, but I think that there > > needs to be some code elsewhere too, to catch the case where > > I_DIRTY_PAGES is being cleared, but the time fields still need > > to be updated. > > Agreed. The mtime and ctime should probably also be updated > when I_DIRTY_PAGES is cleared. > > The alternative would be to remember that the inode had been > dirty in the past, and have the mtime and ctime updated on > msync or close - which would be more complex.
Adding the new flag (AS_MCTIME) has been already suggested by Peter Staubach in his first solution for this bug. Now I understand that the AS_MCTIME flag is required for fixing the bug. > > -- > All rights reversed. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
