On Tue, Mar 09, 2021 at 09:46:43AM +0530, Viresh Kumar wrote: > On 08-03-21, 14:52, Will Deacon wrote: > > On Mon, Mar 01, 2021 at 12:21:17PM +0530, Viresh Kumar wrote: > > > +EXPORT_SYMBOL_GPL(topology_set_scale_freq_source); > > > > I don't get why you need to export this in this patch. The arm64 topology > > code is never built as a module. > > > > > +EXPORT_SYMBOL_GPL(topology_clear_scale_freq_source); > > > > Same here. > > > > > +EXPORT_SYMBOL_GPL(freq_scale); > > > > And here. > > After this patch, any part of the kernel can use these > helpers/variables to run their own implementation of tick-freq-scale > and so this patch looked to be the right place for that to me. > > And the second patch in the series updates the CPPC cpufreq driver > (tristate) to use these exported symbols, so we have the first user > who needs the exported symbols as well.
Ok, then how about putting the exports in their own patch that immediately precedes the patch which uses them? I think that would make it much clearer. > > This one probably wants a less generic name as well if it's going > > to be exported. > > x86 names it arch_freq_scale, perhaps we should stick to that instead. Sounds like a improvement, thanks. Will
