On Wed, 2008-01-16 at 22:11 -0500, H. Peter Anvin wrote: > Harvey Harrison wrote: > > On Wed, 2008-01-16 at 23:27 +0100, Andi Kleen wrote: > >> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> > >> > >> --- > >> arch/x86/mm/fault_32.c | 2 +- > > > > Could use exactly the same in fault_64.c > > > >> #ifdef CONFIG_X86_32 > >> - "%s%s[%d]: segfault at %08lx ip %08lx sp %08lx error > >> %lx\n", > >> + "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error > >> %lx\n", > >> #else > >> "%s%s[%d]: segfault at %lx ip %lx sp %lx error %lx\n", > >> #endif > > > > With the ongoing unification work, it would be nice if we could come > > up with a way to unify printks like this. Anyone have any bright ideas > > on a format that will keep the current alignment on 32 and 64 bit with > > the same syntax, or will these tiny ifdefs keep sprouting? > > > > Casting to (void *) and using %p is probably your best bet. That's what > it really is anyway. > > Note: in the kernel right now, %p doesn't have the leading 0x prefix, > which it probably should...
Well, that won't exactly be the nicest looking solution in places, maybe a shorthand could be developed for this, or could another format specifier be added that implicitly does the (void *) cast? (%P perhaps) Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
