On Mon, Mar 22, 2021 at 05:11:13PM +0100, Greg KH wrote: > On Mon, Mar 22, 2021 at 03:31:43PM +0100, Fabio Aiuto wrote: > > remove debug_priv argument so function prototype can be > > easily moved away > > > > Signed-off-by: Fabio Aiuto <fabioaiut...@gmail.com> > > --- > > drivers/staging/rtl8723bs/core/rtw_recv.c | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c > > b/drivers/staging/rtl8723bs/core/rtw_recv.c > > index 9ef2408ded57..e2a6afed723c 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_recv.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c > > @@ -1983,13 +1983,13 @@ int enqueue_reorder_recvframe(struct > > recv_reorder_ctrl *preorder_ctrl, union rec > > > > } > > > > -void recv_indicatepkts_pkt_loss_cnt(struct debug_priv *pdbgpriv, u64 > > prev_seq, u64 current_seq); > > -void recv_indicatepkts_pkt_loss_cnt(struct debug_priv *pdbgpriv, u64 > > prev_seq, u64 current_seq) > > +u64 recv_indicatepkts_pkt_loss_cnt(u64 prev_seq, u64 current_seq); > > But you did not drop the function prototype, why keep it? > > And shouldn't this be static? > > thanks, > > greg k-h
I moved it in a header file in the next patch [6/11]. However is better a static function when possible and drop the prototype.
