From: Parav Pandit <pa...@nvidia.com>

Use newly introduced client_supported() callback to avoid client
additional if the RDMA device is not of IB type.

Signed-off-by: Parav Pandit <pa...@nvidia.com>
Signed-off-by: Leon Romanovsky <leo...@nvidia.com>
---
 net/smc/smc_ib.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/net/smc/smc_ib.c b/net/smc/smc_ib.c
index 6b65c5d1f957..f7186d9d1299 100644
--- a/net/smc/smc_ib.c
+++ b/net/smc/smc_ib.c
@@ -767,6 +767,11 @@ void smc_ib_ndev_change(struct net_device *ndev, unsigned 
long event)
        mutex_unlock(&smc_ib_devices.mutex);
 }
 
+static bool smc_client_supported(struct ib_device *ibdev)
+{
+       return ibdev->node_type == RDMA_NODE_IB_CA;
+}
+
 /* callback function for ib_register_client() */
 static int smc_ib_add_dev(struct ib_device *ibdev)
 {
@@ -774,9 +779,6 @@ static int smc_ib_add_dev(struct ib_device *ibdev)
        u8 port_cnt;
        int i;
 
-       if (ibdev->node_type != RDMA_NODE_IB_CA)
-               return -EOPNOTSUPP;
-
        smcibdev = kzalloc(sizeof(*smcibdev), GFP_KERNEL);
        if (!smcibdev)
                return -ENOMEM;
@@ -840,6 +842,7 @@ static struct ib_client smc_ib_client = {
        .name   = "smc_ib",
        .add    = smc_ib_add_dev,
        .remove = smc_ib_remove_dev,
+       .is_supported = smc_client_supported,
 };
 
 int __init smc_ib_register_client(void)
-- 
2.30.2

Reply via email to