On 4/6/21 11:47 AM, Oleg Nesterov wrote: > On 04/04, Jens Axboe wrote: >> >> +struct callback_head *task_work_cancel_match(struct task_struct *task, >> + bool (*match)(struct callback_head *, void *data), void *data); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Feel free to ignore, but how about "typedef task_work_match_t" ? > > Either way, > > Reviewed-by: Oleg Nesterov <o...@redhat.com>
Thanks! I actually didn't add that deliberately, as I think they just tend to hide it. If I see the above, I know what the callback func looks like without having to find the definition of task_work_match_t. -- Jens Axboe
