Quoting Baoquan He (2021-04-08 03:17:43) > On 04/07/21 at 07:03pm, Petr Mladek wrote: > > On Tue 2021-03-30 20:05:20, Stephen Boyd wrote: > > > We can use the vmlinux_build_id array here now instead of open coding > > > it. This mostly consolidates code. > > > > > > Cc: Jiri Olsa <[email protected]> > > > Cc: Alexei Starovoitov <[email protected]> > > > Cc: Jessica Yu <[email protected]> > > > Cc: Evan Green <[email protected]> > > > Cc: Hsin-Yi Wang <[email protected]> > > > Cc: Dave Young <[email protected]> > > > Cc: Baoquan He <[email protected]> > > > Cc: Vivek Goyal <[email protected]> > > > Cc: <[email protected]> > > > Signed-off-by: Stephen Boyd <[email protected]> > > > --- > > > include/linux/crash_core.h | 6 +----- > > > kernel/crash_core.c | 41 ++------------------------------------ > > > 2 files changed, 3 insertions(+), 44 deletions(-) > > > > > > diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h > > > index 206bde8308b2..fb8ab99bb2ee 100644 > > > --- a/include/linux/crash_core.h > > > +++ b/include/linux/crash_core.h > > > @@ -39,7 +39,7 @@ phys_addr_t paddr_vmcoreinfo_note(void); > > > #define VMCOREINFO_OSRELEASE(value) \ > > > vmcoreinfo_append_str("OSRELEASE=%s\n", value) > > > #define VMCOREINFO_BUILD_ID(value) \ > > > - vmcoreinfo_append_str("BUILD-ID=%s\n", value) > > > + vmcoreinfo_append_str("BUILD-ID=%20phN\n", value) > > I may miss something, wondering why we need add '20' here.
The build ID is an array of 20 bytes and this format is to print 20 bytes in hex.
