Hello Mathieu, On 4/12/21 10:02 PM, Mathieu Poirier wrote: > On Tue, Mar 23, 2021 at 01:27:30PM +0100, Arnaud Pouliquen wrote: >> This series is the second step in the division of the series [1]: >> "Introducing a Generic IOCTL Interface for RPMsg Channel Management". >> >> The purpose of this patchset is to: >> - split the control code related to the control >> and the endpoint. >> - define the rpmsg-raw channel, associated with the rpmsg char device to >> allow it to be instantiated using a name service announcement. >> >> An important point to keep in mind for this patchset is that the concept of >> channel is associated with a default endpoint. To facilitate communication >> with the remote side, this default endpoint must have a fixed address. >> >> Consequently, for this series, I made a design choice to fix the endpoint >> on the "rpmsg-raw" channel probe, and not allow to create/destroy an endpoint >> on FS open/close. >> >> This is only applicable for channels probed by the rpmsg bus. The behavior, >> using the RPMSG_CREATE_EPT_IOCTL and RPMSG_DESTROY_EPT_IOCTL controls, is >> preserved. >> >> The next steps should be to correct this: >> Introduce the IOCTLs RPMSG_CREATE_DEV_IOCTL and RPMSG_DESTROY_DEV_IOCTL >> to instantiate the rpmsg devices >> >> [1]: >> https://patchwork.kernel.org/project/linux-remoteproc/list/?series=435523 >> >> Arnaud Pouliquen (7): >> rpmsg: char: Export eptdev create an destroy functions >> rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl >> rpmsg: Update rpmsg_chrdev_register_device function >> rpmsg: char: Introduce __rpmsg_chrdev_create_eptdev function >> rpmsg: char: Introduce a rpmsg driver for the rpmsg char device >> rpmsg: char: No dynamic endpoint management for the default one >> rpmsg: char: Return error if user try to destroy a default endpoint. >> > > I am done reviewing this set.
Thanks for the review! I will integrate all your remarks in my next revision. Since I haven't seen any major problems, I hope to send it today or tomorrow. Regards, Arnaud > > Thanks, > Mathieu > >> drivers/rpmsg/Kconfig | 9 ++ >> drivers/rpmsg/Makefile | 1 + >> drivers/rpmsg/qcom_glink_native.c | 2 +- >> drivers/rpmsg/qcom_smd.c | 2 +- >> drivers/rpmsg/rpmsg_char.c | 221 +++++++++------------------- >> drivers/rpmsg/rpmsg_char.h | 50 +++++++ >> drivers/rpmsg/rpmsg_ctrl.c | 233 ++++++++++++++++++++++++++++++ >> drivers/rpmsg/rpmsg_internal.h | 8 +- >> drivers/rpmsg/virtio_rpmsg_bus.c | 2 +- >> 9 files changed, 368 insertions(+), 160 deletions(-) >> create mode 100644 drivers/rpmsg/rpmsg_char.h >> create mode 100644 drivers/rpmsg/rpmsg_ctrl.c >> >> -- >> 2.17.1 >>
