On Thu, 15 Apr 2021, Fabio Aiuto wrote:
> On Wed, Apr 14, 2021 at 07:11:29PM +0100, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c: In function
> > ‘CardDisableRTL8723BSdio’:
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c:881:5: warning: variable
> > ‘ret’ set but not used [-Wunused-but-set-variable]
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c: In function
> > ‘CardDisableRTL8723BSdio’:
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c:881:5: warning: variable
> > ‘ret’ set but not used [-Wunused-but-set-variable]
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c: In function
> > ‘CardDisableRTL8723BSdio’:
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c:881:5: warning: variable
> > ‘ret’ set but not used [-Wunused-but-set-variable]
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c: In function
> > ‘CardDisableRTL8723BSdio’:
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c:881:5: warning: variable
> > ‘ret’ set but not used [-Wunused-but-set-variable]
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c: In function
> > ‘CardDisableRTL8723BSdio’:
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c:881:5: warning: variable
> > ‘ret’ set but not used [-Wunused-but-set-variable]
> >
> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> > Cc: Fabio Aiuto <fabioaiut...@gmail.com>
> > Cc: Stanley@BB.SD3
> > Cc: linux-stag...@lists.linux.dev
> > Signed-off-by: Lee Jones <lee.jo...@linaro.org>
> > ---
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > index f6d734dd1a24f..60d3d6d1ba678 100644
> > --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > @@ -878,10 +878,9 @@ static void CardDisableRTL8723BSdio(struct adapter
> > *padapter)
> > {
> > u8 u1bTmp;
> > u8 bMacPwrCtrlOn;
> > - u8 ret = _FAIL;
> >
> > /* Run LPS WL RFOFF flow */
> > - ret = HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK,
> > PWR_INTF_SDIO_MSK, rtl8723B_enter_lps_flow);
> > + HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK,
> > PWR_INTF_SDIO_MSK, rtl8723B_enter_lps_flow);
> >
> > /* ==== Reset digital sequence ====== */
> >
> > @@ -909,9 +908,8 @@ static void CardDisableRTL8723BSdio(struct adapter
> > *padapter)
> > /* ==== Reset digital sequence end ====== */
> >
> > bMacPwrCtrlOn = false; /* Disable CMD53 R/W */
> > - ret = false;
> > rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn);
> > - ret = HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK,
> > PWR_INTF_SDIO_MSK, rtl8723B_card_disable_flow);
> > + HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK,
> > PWR_INTF_SDIO_MSK, rtl8723B_card_disable_flow);
> > }
> >
> > static u32 rtl8723bs_hal_deinit(struct adapter *padapter)
>
> perhaps it's better to check the return value and return it
> to the caller if something goes wrong,
No problem. Will fix.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
