* Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:

> On Jan 27, 2008 10:45 PM, Dmitri Vorobiev <[EMAIL PROTECTED]> wrote:
> > > -  math_abort(FPU_info,SIGILL);
> > > +  math_abort(FPU_info , SIGILL);
> >
> > Looks like you're trading bad for worse here.
> 
> Should I make it read like math_abort(FPU_info, SIGILL); ?

yeah, that's the correct one.

> > While you're at it, please think about adding proper KERN_ facility to 
> > these printk() calls.
> 
> Yes, basically all the warnings are about missing KERN_. Do you want 
> me to add KERN_ERR to all the above printk?

Do that in a separate patch though, as it changes strings. (and hence 
the checking for 'did the object md5 change' misfires)

        Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to