On Tue, May 20, 2025 at 08:39:07PM +0200, Vincent Knecht via B4 Relay wrote:
> From: Vincent Knecht <vincent.kne...@mailoo.org>
>
> The camera subsystem for the MSM8939 is the same as MSM8916 except with
> 3 CSID instead of 2, and some higher clock rates.
>
> As a quirk, this SoC needs writing values to 2 VFE VBIF registers
> (see downstream msm8939-camera.dtsi vbif-{regs,settings} properties).
> This fixes black stripes across sensor and garbage in CSID TPG outputs.
>
> Add support for the MSM8939 camera subsystem.
>
> Signed-off-by: Vincent Knecht <vincent.kne...@mailoo.org>
> ---
> drivers/media/platform/qcom/camss/camss-csiphy.c | 1 +
> drivers/media/platform/qcom/camss/camss-ispif.c | 8 +-
> drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 11 ++
> drivers/media/platform/qcom/camss/camss-vfe-vbif.c | 7 +
> drivers/media/platform/qcom/camss/camss-vfe.c | 1 +
> drivers/media/platform/qcom/camss/camss.c | 157
> +++++++++++++++++++++
> drivers/media/platform/qcom/camss/camss.h | 1 +
> 7 files changed, 184 insertions(+), 2 deletions(-)
>
> @@ -742,6 +744,15 @@ static void vfe_set_qos(struct vfe_device *vfe)
> writel_relaxed(val, vfe->base + VFE_0_BUS_BDG_QOS_CFG_5);
> writel_relaxed(val, vfe->base + VFE_0_BUS_BDG_QOS_CFG_6);
> writel_relaxed(val7, vfe->base + VFE_0_BUS_BDG_QOS_CFG_7);
> +
> + /* SoC-specific VBIF settings */
> + if (vfe->res->has_vbif) {
> + ret = vfe_vbif_apply_settings(vfe);
> + if (ret < 0)
> + dev_err_ratelimited(vfe->camss->dev,
> + "VFE: VBIF error %d\n",
> + ret);
> + }
> }
This chunk should probably go to the previous patch.
>
> static void vfe_set_ds(struct vfe_device *vfe)
--
With best wishes
Dmitry
