On 5/20/25 8:39 PM, Vincent Knecht via B4 Relay wrote:
> From: Vincent Knecht <vincent.kne...@mailoo.org>
> 
> Add the camera subsystem and CCI used to interface with cameras on the
> Snapdragon 615.
> 
> Signed-off-by: Vincent Knecht <vincent.kne...@mailoo.org>
> ---

[...]

> +                     interrupts = <GIC_SPI 78 IRQ_TYPE_EDGE_RISING>,
> +                                  <GIC_SPI 79 IRQ_TYPE_EDGE_RISING>,
> +                                  <GIC_SPI 51 IRQ_TYPE_EDGE_RISING>,
> +                                  <GIC_SPI 52 IRQ_TYPE_EDGE_RISING>,
> +                                  <GIC_SPI 153 IRQ_TYPE_EDGE_RISING>,
> +                                  <GIC_SPI 55 IRQ_TYPE_EDGE_RISING>,
> +                                  <GIC_SPI 57 IRQ_TYPE_EDGE_RISING>;
> +                     interrupt-names = "csiphy0",
> +                                       "csiphy1",
> +                                       "csid0",
> +                                       "csid1",
> +                                       "csid2",

docs don't mention the interrupt of csid0, but this soc is very old so
something might have gotten lost..

[...]

> +             cci: cci@1b0c000 {
> +                     compatible = "qcom,msm8916-cci", "qcom,msm8226-cci";
> +                     #address-cells = <1>;
> +                     #size-cells = <0>;

please move these two above status

> +                     reg = <0x01b0c000 0x1000>;
> +                     interrupts = <GIC_SPI 50 IRQ_TYPE_EDGE_RISING>;
> +
> +                     clocks = <&gcc GCC_CAMSS_ISPIF_AHB_CLK>,
> +                              <&gcc GCC_CAMSS_TOP_AHB_CLK>,
> +                              <&gcc GCC_CAMSS_CCI_AHB_CLK>,
> +                              <&gcc GCC_CAMSS_CCI_CLK>,
> +                              <&gcc GCC_CAMSS_AHB_CLK>;

camss_ahb should be unnecessary, maybe ispif_ahb too

Konrad

Reply via email to