On 5/25/25 9:25 PM, Vincent Knecht via B4 Relay wrote: > This series adds CAMSS support for MSM8939. > It's mostly identical to MSM8916, except for some clocks > and an additional CSI. > > To fix black stripes across sensor output, and garbage in > CSID TPG output, 2 VFE VBIF register settings are needed. > So the 1st patch adds helper functions to do just that. > > Patch 1: adds helper for VFE VBIF settings > Patch 2: adds CAMSS_8x39 version in CAMSS driver > Patch 3: documents qcom,msm8939-camss DT bindings > Patch 4: adds camss and cci in msm8939.dtsi > > Signed-off-by: Vincent Knecht <vincent.kne...@mailoo.org> > --- > Changes in v2: > - Patch 1: > - Fix devm_platform_ioremap_resource_byname line to not end with > opening parenthesis (media-ci/1-checkpatch) > - Move camss-vfe-4-1.c handling of VBIF previously in patch 2 here > (Dmitry) > - Patch 2: > - Declare regulators in PHY entries, not CSID ones (Bryan) > - Patch 3: (bindings) > - Fix bindings checks for new errors (Rob) > - Fix properties ordering, code-style and example (Krzysztof) > - Sort reg-names, clock-names and interrupt-names alphanumerically (Bryan) > - Patch 4: (dtsi) > - Move #address/#size cells before status (Konrad) > - Aligned CCI with msm8916, thus removing ispif_ahb mention (Konrad) > If "camss_ahb should be unnecessary", it's still required by > qcom,i2c-cci.yaml
Give it a shot (with camss disabled so that the clock isn't on) - make sure it's off and see if you can still access i2c. If it turns out it's fine, we'll fix up the bindings instead Konrad
