On Mon, Jun 30, 2025 at 10:01:35AM +0200, Luca Weiss wrote: > Hi Konrad, > > On Fri Jun 27, 2025 at 5:14 PM CEST, Luca Weiss wrote: > > On Fri Jun 27, 2025 at 5:10 PM CEST, Konrad Dybcio wrote: > >> On 6/25/25 11:12 AM, Luca Weiss wrote: > >>> Document and add the clock drivers for GCC, CAMCC, DISPCC, GPUCC and > >>> VIDEOCC on the SM7635 SoC. > >>> > >>> Signed-off-by: Luca Weiss <[email protected]> > >>> --- > >>> Luca Weiss (10): > >>> dt-bindings: clock: qcom: document the SM7635 Global Clock > >>> Controller > >>> clk: qcom: Add Global Clock controller (GCC) driver for SM7635 > >>> dt-bindings: clock: qcom: document the SM7635 Camera Clock > >>> Controller > >>> clk: qcom: Add Camera Clock controller (CAMCC) driver for SM7635 > >>> dt-bindings: clock: qcom: document the SM7635 Display Clock > >>> Controller > >>> clk: qcom: Add Display Clock controller (DISPCC) driver for SM7635 > >>> dt-bindings: clock: qcom: document the SM7635 GPU Clock Controller > >>> clk: qcom: Add Graphics Clock controller (GPUCC) driver for SM7635 > >>> dt-bindings: clock: qcom: document the SM7635 Video Clock Controller > >>> clk: qcom: Add Video Clock controller (VIDEOCC) driver for SM7635 > >> > >> We had a massive yak shaving patchset go in this season, please move > >> the magic settings in .probe to qcom_cc_driver_data {} > > > > Okay cool, I found them > > https://lore.kernel.org/linux-arm-msm/[email protected]/ > > For camcc, gpucc and videocc it seems quite simple to follow these > changes. > > For dispcc I don't know what to do with this line. > > /* Enable clock gating for MDP clocks */ > regmap_update_bits(regmap, DISP_CC_MISC_CMD, 0x10, 0x10);
Use clk_regs_configure() callback to set this bit. > > Do I just keep the regmap references in this probe function and just > move the clk_lucid_ole_pll_configure & qcom_branch_set_clk_en to the > config struct? > > And similar for gcc, I can move the qcom_branch_set_clk_en calls there > but the qcom_cc_register_rcg_dfs needs to be kept. Would you mind extnding struct qcom_cc_desc with args to call qcom_cc_register_rcg_dfs() and call it from qcom_cc_really_probe()? > > Does that sound okay, or what exactly is the desired outcome of the > requested changes? > > Regards > Luca > > > > >> > >> Konrad > -- With best wishes Dmitry
