On 10/07/25 09:23AM, Dave Jiang wrote:


On 6/17/25 5:39 AM, Neeraj Kumar wrote:
Add cxl_find_root_decoder to find root decoder on cxl bus. It is used to
find root decoder during region creation

Signed-off-by: Neeraj Kumar <s.nee...@samsung.com>
---
 drivers/cxl/core/port.c | 26 ++++++++++++++++++++++++++
 drivers/cxl/cxl.h       |  1 +
 2 files changed, 27 insertions(+)

diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
index 2452f7c15b2d..94d9322b8e38 100644
--- a/drivers/cxl/core/port.c
+++ b/drivers/cxl/core/port.c
@@ -513,6 +513,32 @@ struct cxl_switch_decoder *to_cxl_switch_decoder(struct 
device *dev)
 }
 EXPORT_SYMBOL_NS_GPL(to_cxl_switch_decoder, "CXL");

+static int match_root_decoder(struct device *dev, void *data)
+{
+       return is_root_decoder(dev);
+}
+
+/**
+ * cxl_find_root_decoder() - find a cxl root decoder on cxl bus
+ * @port: any descendant port in root-cxl-port topology

s/root-cxl-port/CXL port/

Please add a comment noting that the caller of this function must call 
put_device() when done as a device ref is taken via device_find_child().


Thanks Dave for pointing this, Sure I will update it accordingly.


+ */
+struct cxl_root_decoder *cxl_find_root_decoder(struct cxl_port *port)

cxl_port_find_root_decoder(). There is a cxl_find_root_decoder() already in 
core/region.c and could cause potential symbol clash.

DJ


Sure Dave, I will rename it while rebasing for next patch-set


Regards,
Neeraj


Reply via email to