> -----Original Message----- > From: Hansen, Dave <dave.han...@intel.com> > Sent: Friday, August 1, 2025 7:45 PM > To: Reshetova, Elena <elena.reshet...@intel.com> > Cc: jar...@kernel.org; sea...@google.com; Huang, Kai > <kai.hu...@intel.com>; mi...@kernel.org; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; x...@kernel.org; Mallick, Asit K > <asit.k.mall...@intel.com>; Scarlata, Vincent R > <vincent.r.scarl...@intel.com>; > Cai, Chong <cho...@google.com>; Aktas, Erdem <erdemak...@google.com>; > Annapurve, Vishal <vannapu...@google.com>; Bondarevska, Nataliia > <bond...@google.com>; Raynor, Scott <scott.ray...@intel.com> > Subject: Re: [PATCH v10 2/6] x86/sgx: Introduce functions to count the > sgx_(vepc_)open() > > On 8/1/25 04:25, Elena Reshetova wrote: > > Note: the sgx_inc_usage_count prototype is defined to return > > int for the cleanliness of the follow-up patches. When the > > EUPDATESVN SGX instruction will be enabled in the follow-up patch, > > the sgx_inc_usage_count will start to return int. > > Please use parenthesis for function_names().
Sure, will fix. > > Second, sgx_inc_usage_count() _already_ returns 'int'. Now. In this patch. > > So I'm confused what this is trying to say. > > Is this trying to say that sgx_inc_usage_count() always returns success > (0) for now, but the future implementation can fail? *That's* why it > needs to have an 'int' return type. Yes, I will rephrase this better. Best Regards, Elena.
