> -----Original Message----- > From: Hansen, Dave <dave.han...@intel.com> > Sent: Monday, August 4, 2025 5:20 PM > To: Reshetova, Elena <elena.reshet...@intel.com> > Cc: jar...@kernel.org; sea...@google.com; Huang, Kai > <kai.hu...@intel.com>; mi...@kernel.org; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; x...@kernel.org; Mallick, Asit K > <asit.k.mall...@intel.com>; Scarlata, Vincent R > <vincent.r.scarl...@intel.com>; > Cai, Chong <cho...@google.com>; Aktas, Erdem <erdemak...@google.com>; > Annapurve, Vishal <vannapu...@google.com>; Bondarevska, Nataliia > <bond...@google.com>; Raynor, Scott <scott.ray...@intel.com> > Subject: Re: [PATCH v10 4/6] x86/sgx: Define error codes for use by > ENCLS[EUPDATESVN] > > On 8/4/25 00:21, Reshetova, Elena wrote: > ... > >>> + EUPDATESVN = 0x18, > >>> }; > >> > >> This update is not consistent with the changelog nor the patch subject. > > > > I can remove the alignment fix. > > It's not the alignment. > > It's the definition of EUPDATESVN that goes completely unmentioned.
Yes, good catch, this should be moved to the next patch indeed. > > ... > >> Ideally, we find a way to relay this in a very succinct way. > > > > Could you please elaborate what you mean by this? > > Changing the description? The name or? > > Relaying it in the comment next to the definition would be best. Sure, will try to extend the current description to convey it better. Best Regards, Elena.
