On 31/07/2025 18:01, Muhammad Usama Anjum wrote:
> [...]
>
> diff --git a/tools/testing/selftests/mm/pkey_sighandler_tests.c
> b/tools/testing/selftests/mm/pkey_sighandler_tests.c
> index b5e076a564c95..302fef54049c8 100644
> --- a/tools/testing/selftests/mm/pkey_sighandler_tests.c
> +++ b/tools/testing/selftests/mm/pkey_sighandler_tests.c
> @@ -41,7 +41,7 @@ static siginfo_t siginfo = {0};
> * syscall will attempt to access the PLT in order to call a library function
> * which is protected by MPK 0 which we don't have access to.
> */
> -static inline __always_inline
> +static __always_inline
Thanks for this, I had this fix locally but never got to post it!
> long syscall_raw(long n, long a1, long a2, long a3, long a4, long a5, long
> a6)
> {
> unsigned long ret;
> diff --git a/tools/testing/selftests/mm/split_huge_page_test.c
> b/tools/testing/selftests/mm/split_huge_page_test.c
> index 05de1fc0005b7..a85b2e393e4e8 100644
> --- a/tools/testing/selftests/mm/split_huge_page_test.c
> +++ b/tools/testing/selftests/mm/split_huge_page_test.c
> @@ -296,10 +296,8 @@ void split_file_backed_thp(int order)
> ksft_exit_fail_msg("Unable to create a tmpfs for testing\n");
>
> status = snprintf(testfile, INPUT_MAX, "%s/thp_file", tmpfs_loc);
> - if (status >= INPUT_MAX) {
> + if (status >= INPUT_MAX)
> ksft_exit_fail_msg("Fail to create file-backed THP split
> testing file\n");
> - goto cleanup;
At that point the mount() call has succeeded so I think we do want to
keep the goto and just print the error message instead of calling
replace ksft_exit_fail_msg().
- Kevin
> - }
>
> fd = open(testfile, O_CREAT|O_RDWR, 0664);
> if (fd == -1) {
